[FrameworkBundle] Fix session.attribute_bag service definition #36506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest changing the factory method: it should be |
|
I thought about this but |
|
It's not dynamic in the context of wiring. |
fancyweb
force-pushed
the
session-get-attribute-bag
branch
2 times, most recently
from
05220fa
to
293d4e4
Compare
fancyweb
changed the title
fancyweb
force-pushed
the
session-get-attribute-bag
branch
from
293d4e4
to
76072c6
Compare
nicolas-grekas
approved these changes
Apr 20, 2020
xabbuh
approved these changes
Apr 20, 2020
smithandre
approved these changes
Apr 20, 2020
|
Thank you @fancyweb. |
This was referenced Apr 28, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like in #36063, the fact the the
getAttributeBagmethod is private was forgotten. It cannot be used as the factory method. I guess we can make it public. Should it maybe marked@internal?