Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Messenger] "login" falsely reported as invalid option #37618

Closed
Tobion opened this issue Jul 20, 2020 · 0 comments · Fixed by #38612
Closed

[Messenger] "login" falsely reported as invalid option #37618

Tobion opened this issue Jul 20, 2020 · 0 comments · Fixed by #38612
Labels
Bug Messenger Status: Needs Review

Comments

@Tobion
Copy link
Member

Tobion commented Jul 20, 2020 •
edited

Symfony version(s) affected: 5.1

Description
Since #34925

User Deprecated: Since symfony/messenger 5.1: Invalid option(s) "login" passed to the AMQP Messenger transport. Passing invalid options is deprecated.

But login is a valid option that being used by \AMQPConnection::__construct, see also

symfony/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php

Line 191 in 8a7c776

$amqpOptions['login'] = $parsedUrl['user'];

@Tobion Tobion added the Bug label Jul 20, 2020
@Tobion Tobion mentioned this issue Jul 20, 2020
Merged
@W0rma W0rma mentioned this issue Oct 17, 2020
Merged
nicolas-grekas added a commit that referenced this issue Oct 19, 2020
@nicolas-grekas
bug #38612 [Messenger/Amqp] Allow setting option "login" in DSN (W0rma)
bbb220c 
This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger/Amqp] Allow setting option "login" in DSN

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37618
| License       | MIT
| Doc PR        |

Commits
-------

43c0577 Allow setting AMQP option "login"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Messenger/Amqp] Allow setting option "login" in DSN W0rma/symfony
3 participants
@nicolas-grekas @Tobion @carsonbot