Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Messenger/Amqp] Allow setting option "login" in DSN #38612

Merged
merged 1 commit into from
Oct 19, 2020
Merged

[Messenger/Amqp] Allow setting option "login" in DSN #38612

merged 1 commit into from
Oct 19, 2020

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Oct 17, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37618
License MIT
Doc PR

@W0rma W0rma requested a review from sroze as a code owner October 17, 2020 18:56
@W0rma W0rma changed the base branch from 5.x to 5.1 October 17, 2020 18:56
@derrabus derrabus added this to the 5.1 milestone Oct 17, 2020
Nyholm
Nyholm approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@chalasr
Copy link
Member

chalasr commented Oct 18, 2020

Should we document it in

symfony/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php

Line 122 in 8f12f96

* Available options:
?

@W0rma W0rma force-pushed the 37618-allow-login-option-amqp branch from 8f12f96 to 43c0577 Compare October 18, 2020 11:03
@W0rma
Copy link
Contributor Author

W0rma commented Oct 18, 2020

Should we document it in https://github.com/symfony/symfony/blob/8f12f968f53e978d98333e5198a83b3d6f374e05/src/Symfony/Component>

@chalasr Makes sense - thank you for the hint. Done.

@nicolas-grekas nicolas-grekas changed the title [Amqp] Allow setting option "login" in DSN [Messenger/Amqp] Allow setting option "login" in DSN Oct 19, 2020
@nicolas-grekas
Copy link
Member

Thank you @W0rma.

@nicolas-grekas nicolas-grekas merged commit bbb220c into symfony:5.1 Oct 19, 2020
This was referenced Oct 28, 2020
Merged
Merged
@W0rma W0rma deleted the 37618-allow-login-option-amqp branch May 24, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@chalasr chalasr chalasr approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Messenger] "login" falsely reported as invalid option
6 participants
@W0rma @chalasr @nicolas-grekas @Nyholm @derrabus @carsonbot