[PhpUnitBridge] Fix some errors when using serialized deprecations

[l-vo]

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

During the refactoring for #29211, some very minor problems seamed to appear. I created #31382 for fixing one of them but I forgot two others; sorry for that. Both problems occurs when using @runInSeparateProcess in tests too:

• deprecation isSelf condition is inverted when using runInSeparateProcess
• wrong trace stack is used to determine isIndirect state of the deprecation when using runInSeparateProcess

[l-vo]

Tests fail, I think it's because they use the PhpUnitBridge of the master branch.

[greg0ire]

I reproduce the build failure locally. I'm using php 7.3, what about you? Also, I'm running the tests from the directory of the component, src/Symfony/Bridge/PhpUnit

[greg0ire]

Also, tests fail when I run them in another of the supported ways (which is not used in CI):

phpunit src/Symfony/Bridge/PhpUnit             
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Testing src/Symfony/Bridge/PhpUnit
..........S....................FFF..EE...................S......  64 / 64 (100%)

Time: 467 ms, Memory: 10.00MB

There were 2 errors:

1) Symfony\Bridge\PhpUnit\Tests\DeprecationErrorHandler\DeprecationTest::testIsIndirectUsesRightTrace with data set #1 (false, 'a:4:{s:11:"deprecation";s:22:...it";}}', array(array('myfunc1'), array('Symfony\Bridge\PhpUnit\Legacy...rForV5', 'mymethod')))
Undefined index: function

/home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php:151

2) Symfony\Bridge\PhpUnit\Tests\DeprecationErrorHandler\DeprecationTest::testIsIndirectUsesRightTrace with data set #2 (true, 'a:4:{s:11:"deprecation";s:22:...it";}}', array(array('myfunc1'), array('Symfony\Bridge\PhpUnit\Legacy...rForV5', 'mymethod')))
Undefined index: function

/home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php:151

--

There were 3 failures:

1) Symfony\Bridge\PhpUnit\Tests\DeprecationErrorHandler\DeprecationTest::testIsSelf with data set #2 (true, 'a:4:{s:5:"class";s:0:"";s:6:"...:0:{}}', 'Symfony\Bridge\PhpUnit\Legacy...rForV5', '')
Failed asserting that false matches expected true.

/home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php:101

2) Symfony\Bridge\PhpUnit\Tests\DeprecationErrorHandler\DeprecationTest::testIsSelf with data set #3 (true, 'a:5:{s:5:"class";s:0:"";s:6:"...:0:{}}', 'Symfony\Bridge\PhpUnit\Legacy...rForV5', '')
Failed asserting that false matches expected true.

/home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php:101

3) Symfony\Bridge\PhpUnit\Tests\DeprecationErrorHandler\DeprecationTest::testIsSelf with data set #4 (false, 'a:5:{s:5:"class";s:0:"";s:6:"...:0:{}}', 'Symfony\Bridge\PhpUnit\Legacy...rForV5', '')
Failed asserting that true matches expected false.

/home/greg/dev/symfony/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php:101

Same with simply phpunit , but that's probably because it is mixing old and new code, might be fixed one your code is merged.

[greg0ire]

@l-vo how do you run the test suite locally? This is how I proceed:

cd src/Symfony/Bridge/PhpUnit
phpunit

EDIT: and it fails on my machine, what about you?

[l-vo]

@greg0ire from the repository root:

$ php phpunit src/Symfony/Bridge/PhpUnit

[greg0ire]

Please try to make both methods work. The method that I use is used in CI. You will have to run composer update in the phpunit bridge directory first

[l-vo]

@greg0ire I think I fixed the tests. They still fail on PHP 7.3 (deps=low); it is caused by ProcessIsolationTest which use the modified behavior @runTestsInSeparateProcesses. I don't understand what the CI exactly do but I'm almost sure it's because it uses a not up-to-date version of Deprecation.php (a version from the master branch from a vendor directory created by the CI).

[l-vo]

Status: needs review

[l-vo]

Closed in favour of #33820