Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yaml] support YAML 1.2 octal notation, deprecate YAML 1.1 one #34813

Merged
merged 1 commit into from May 5, 2020
Merged

[Yaml] support YAML 1.2 octal notation, deprecate YAML 1.1 one #34813

merged 1 commit into from May 5, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 4, 2019 •
edited

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Fix #34807
License MIT
Doc PR

@xabbuh xabbuh added this to the next milestone Dec 4, 2019
@xabbuh xabbuh mentioned this pull request Dec 4, 2019
Merged
stof
stof reviewed Dec 4, 2019
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also add support for parsing YAML 1.2 octal notation with 0o ?

src/Symfony/Component/Yaml/Inline.php Outdated Show resolved Hide resolved
src/Symfony/Component/Yaml/Inline.php Outdated
@trigger_error(sprintf('Support for parsing the invalid octal number %s is deprecated since Symfony 5.1.', $scalar), E_USER_DEPRECATED);
}

return '0' == $scalar[1] ? -octdec($octal) : (($raw === (string) $cast) ? $cast : $raw);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a string comparison

@Nyholm
Copy link
Member

Nyholm commented May 3, 2020

@xabbuh Friendly ping

@xabbuh xabbuh force-pushed the issue-34807 branch 2 times, most recently from d3dfffb to 671f0ca Compare May 4, 2020 10:17
@xabbuh xabbuh changed the title [Yaml] deprecate parsing octal numbers with invalid formats [Yaml] support YAML 1.2 octal notation, deprecate YAML 1.1 one May 4, 2020
@xabbuh xabbuh added the Feature label May 4, 2020
@xabbuh xabbuh mentioned this pull request May 4, 2020
Closed
@xabbuh xabbuh modified the milestones: next, 5.1 May 4, 2020
@fabpot
Copy link
Member

fabpot commented May 5, 2020

Thank you @xabbuh.

@fabpot fabpot mentioned this pull request May 5, 2020
Closed
@fabpot fabpot merged commit 09d78cf into symfony:master May 5, 2020
@xabbuh xabbuh deleted the issue-34807 branch May 5, 2020 05:35
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@meyerbaptiste meyerbaptiste mentioned this pull request Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebe cebe cebe left review comments

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Deprecation Feature Status: Reviewed Yaml
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[YAML] Parsing octal numbers: unexpected value conversion and PHP 7.4 notice
6 participants
@xabbuh @Nyholm @fabpot @cebe @stof @carsonbot