[Yaml] Deprecate using the object and const tag without a value #35368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
yaml-deprecate-empty-const-and-object-tags
branch
from
780b68c
to
73d8d4e
Compare
|
Do we really deprecate it in 3.4 AND 4.3,4.4? |
|
@OskarStark We deprecate it on master (5.1). We can't deprecate anything on lower versions. What I meant is that I pushed some code here on master that is already on 3.4 (because 3.4 is not yet fully merged into master). This code is unrelated. |
Thanks for the clarification 👍 |
fancyweb
force-pushed
the
yaml-deprecate-empty-const-and-object-tags
branch
from
73d8d4e
to
89062b9
Compare
fancyweb
changed the title
|
This one is now ready for review 😃 |
fabpot
approved these changes
Feb 3, 2020
nicolas-grekas
approved these changes
Feb 3, 2020
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Feb 3, 2020
…t a value (fancyweb) This PR was merged into the 5.1-dev branch. Discussion ---------- [Yaml] Deprecate using the object and const tag without a value | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | #35332 (comment) | License | MIT | Doc PR | - WIP because it needs 3.4 merged up into master + #35332. Commits ------- 89062b9 [Yaml] Deprecate using the object and const tag without a value
xabbuh
added a commit
that referenced
this pull request
Apr 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because it needs 3.4 merged up into master + #35332.