[HttpKernel] add deprecation for controller:method syntax in ServiceValueResolver

[noemi-salaun]

Q	A
Branch?	4.1
Bug fix?	no
New feature?	no
Deprecations?	yes
Tickets	See #35909
License	MIT
Doc PR	N/A

I apologize in advance, I am not fluent in English

Single colon syntax when referencing a controller as a service is deprecated since Symfony 4.1 but there was no deprecations trigger on runtime.

I found the problem trying to understand the issue #35909

By using Symfony, people have become accustomed to having all the deprecations reported in runtime.

The problem only affects controllers who need to have a service injected as a method argument.

It looks like the deprecation for the controller without injected service argument will be deprecate on v5.1. It seems weird not to deprecate these 2 cases at the same time.

In Symfony\Component\HttpKernel\Controller\ContainerControllerResolver, line 35

    protected function createController($controller)
    {
        if (1 === substr_count($controller, ':')) {
            $controller = str_replace(':', '::', $controller);
            // TODO deprecate this in 5.1
        }

        return parent::createController($controller);
    }

TODO

• I don't know if I should target v4.1 (the start of the deprecation) or v4.4 as suggested by the Q/A
• I didn't add an entry in the CHANGELOG.md as this deprecation is already referenced in https://github.com/symfony/symfony/blob/master/UPGRADE-4.1.md#frameworkbundle

[Tobion]

4.1 is not maintained anymore. Please target 4.4, see https://symfony.com/releases

[stof]

this notation has been un-deprecated in a 4.1 patch release because of the impact on the ecosystem (when trying to support both the 3.4 LTS and 4.x)

[noemi-salaun]

Updated to target v4.4

@stof
Even if the functionality has been un-deprecated, the support is still removed in Symfony 5.0 as the issue #35909 showed

[noemi-salaun]

Apparently it was a bug in v5.0. The feature wasn't fully undeprecated.
See @nicolas-grekas comment #35909 (comment)

This PR is no longer relevant.