Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the reporting of deprecations in twig:lint #36265

Merged
merged 1 commit into from Mar 31, 2020
Merged

Fix the reporting of deprecations in twig:lint #36265

merged 1 commit into from Mar 31, 2020

Commits on Mar 31, 2020

  1. Fix the reporting of deprecations in twig:lint 

    - ensure that the message is rendered when the line detection fails and
  we end up with 0 as line number (the implementation also deals with -1
  which is sometimes used by Twig for errors when it does not know the
  line, even though this should not happen for compile-time errors).
- fix the detection of the line number when the number is at the end of
  the sentence, which happens for the deprecation of filters for
  instance.
    @stof @nicolas-grekas
    stof authored and nicolas-grekas committed Mar 31, 2020
    Copy the full SHA
    c329ca7 View commit details
    Browse the repository at this point in the history