[Serializer] Catch \Throwable in getCacheKey() #36336
Conversation
dunglas
force-pushed
the
serializer-catch-throwable
branch
from
7f404b7
to
ea24bfc
Compare
| 'ignored' => $this->ignoredAttributes, | ||
| 'camelized' => $this->camelizedAttributes, | ||
| ])); | ||
| } catch (\Throwable $exception) { |
There was a problem hiding this comment.
\Exception?
catching \Throwable is a terrible practice, it hides coding issues and helps ppl lose their time to figure out what is broken...
There was a problem hiding this comment.
Not here, it's a very specific edge case, see #36332 (comment)
(We were already catch \Exception)
There was a problem hiding this comment.
If we don't do that, if any value in the context contains a Doctrine entity, an error can be thrown, leading to a 500.
dunglas
force-pushed
the
serializer-catch-throwable
branch
2 times, most recently
from
1b8e7f0
to
86ab77c
Compare
dunglas
force-pushed
the
serializer-catch-throwable
branch
from
86ab77c
to
f4cd9a5
Compare
|
I opened https://bugs.php.net/79447 |
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
|
I've submitted php/php-src#5396 to fix the issue on the PHP side, please have a look. |
|
PR on php-src accepted, this is going to be fixed on PHP's side. Anyone having this issue, please upgrade to PHP >= 7.4.6. |
serialize()can throw\Throwablewith PHP 7+, and it will if you try to serialize a Doctrine entity. As the serialization context will likely contain Doctrine entity, this must be caught.