Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cache] CacheItem with tag is never a hit after expired #36457

Merged
merged 2 commits into from Apr 19, 2020
Merged

[Cache] CacheItem with tag is never a hit after expired #36457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f815b01
[Cache] fix FilesystemTagAwareAdapter failing when a tag link preexists
nicolas-grekas Apr 18, 2020
d082eca
Add reproducer to for hit after update expire cacheItem
alexander-schranz Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/Adapter/FilesystemTagAwareAdapter.php
View file
Open in desktop
Expand Up @@ -107,7 +107,7 @@ protected function doSave(array $values, ?int $lifetime, array $addTagData = [],

$file = $this->getFile($id);

if (!@symlink($file, $this->getFile($id, true, $tagFolder))) {
if (!@symlink($file, $tagLink = $this->getFile($id, true, $tagFolder)) && !is_link($tagLink)) {
@unlink($file);
$failed[] = $id;
}
Expand Down
38 changes: 38 additions & 0 deletions src/Symfony/Component/Cache/Tests/Traits/TagAwareTestTrait.php
View file
Open in desktop
Expand Up @@ -155,4 +155,42 @@ public function testGetMetadata()
$i = $pool->getItem('k');
$this->assertSame(['foo' => 'foo'], $i->getMetadata()[CacheItem::METADATA_TAGS]);
}

public function testRefreshAfterExpires()
{
$pool = $this->createCachePool();
$pool->clear();

$cacheItem = $pool->getItem('test');

$this->assertFalse($cacheItem->isHit());

// write cache with expires
$cacheItem->set('test');
$cacheItem->tag('1234');
$cacheItem->expiresAfter(1);

$pool->save($cacheItem);

$cacheItem = $pool->getItem('test');
$this->assertTrue($cacheItem->isHit());

// wait until expired
sleep(2);

// item should not longer be a hit
$cacheItem = $pool->getItem('test');
$this->assertFalse($cacheItem->isHit());

// update expired item
$cacheItem->set('test');
$cacheItem->tag('1234');
$cacheItem->expiresAfter(1);

$pool->save($cacheItem);

// item should be again a hit
$cacheItem = $pool->getItem('test');
$this->assertTrue($cacheItem->isHit());
}
}