Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Fix missing nullable in CsrfTokenBadge #36518

Merged
merged 1 commit into from Apr 21, 2020
Merged

[Security] Fix missing nullable in CsrfTokenBadge #36518

merged 1 commit into from Apr 21, 2020

Conversation

sstok
Copy link
Contributor

@sstok sstok commented Apr 21, 2020

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Related to #33558 I noticed a minor 馃 bug with the method return-type.

wouterj
wouterj approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 Looks correct. This value is passed into CsrfToken, which is able to handle null values, so I guess fixing the typehint is all that's required

@chalasr
Copy link
Member

chalasr commented Apr 21, 2020

Good catch, thanks @sstok.

@chalasr chalasr merged commit 6b682bf into symfony:master Apr 21, 2020
@chalasr chalasr added this to the next milestone Apr 21, 2020
@sstok sstok deleted the patch-2 branch April 21, 2020 18:32
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sstok @chalasr @fabpot @wouterj @nicolas-grekas @carsonbot