New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cache] skip APCu in chains when the backend is disabled #36555
Conversation
68528f8
to
5a72084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a hack. A useful hack and most likely exactly what you want. But still.
We don’t do the same thing if the Redis extension (or Redis lib) is missing.
The difference is that the availability of the redis backend doesn't vary by runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolas-grekas: I said Redis extension/lib not backend.
I get the argument that this is the only difference between CLI/HTTP. If the Redis extension was missing it would be missing on all runtimes.
👍
and I wrote "backend" to mean "extension" :D The alternative would be to make the ApcuAdapter NOT throw any warning when it's not enabled and on the CLI. But as you explained in one of the issues, there should be some reporting when ApcuAdapter is used directly and it doesn't work at all. In a chain, we can relax this rule - that's what this PR proposes. Thanks for approving :) |
Thank you @nicolas-grekas. |
I think this should do it.