Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DomCrawler] Catch expected ValueError #36915

Merged
merged 1 commit into from May 23, 2020
Merged

[DomCrawler] Catch expected ValueError #36915

merged 1 commit into from May 23, 2020

Conversation

derrabus
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #36872
License MIT
Doc PR N/A

This is #36906 ported to the 4.4 branch.

@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 5d7b7e9 into symfony:4.4 May 23, 2020
@derrabus derrabus deleted the bugfix/4.4-value-error branch May 23, 2020 07:40
This was referenced May 26, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug DomCrawler Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derrabus @nicolas-grekas @carsonbot