Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrameworkBundle] fix type annotation on ControllerTrait::addFlash() #37021

Closed
wants to merge 2 commits into from
Closed

[FrameworkBundle] fix type annotation on ControllerTrait::addFlash() #37021

wants to merge 2 commits into from

Conversation

ThomasLandauer
Copy link
Contributor

Second part of #36913 - see #36913 (comment)
(Couldn't figure out how to include it in the same PR)

@ThomasLandauer
Update ControllerTrait.php
9c5c726 
Second part of #36913 - see #36913 (comment)
(Couldn't figure out how to include it in the same PR)
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 4, 2020
@nicolas-grekas nicolas-grekas changed the title Update ControllerTrait.php [FrameworkBundle] fix type annotation on ControllerTrait::addFlash() Jun 4, 2020
@nicolas-grekas
Copy link
Member

Please mind fabbot's failure.

@ThomasLandauer
Copy link
Contributor Author

I fixed the "Coding Standard" error. For the "Pull Request Contributor Headers", see #36913

@nicolas-grekas
Copy link
Member

Closing in favor of #36913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ThomasLandauer @nicolas-grekas @ro0NL @carsonbot