[Mime] Deprecate Address::fromString() #37175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
mailer-fromString-deprec
branch
3 times, most recently
from
99f23ff
to
f8783ff
Compare
stof
reviewed
Jun 9, 2020
| public static function fromString(string $string): self | ||
| { | ||
| trigger_deprecation('symfony/mime', '5.2', '"%s()" is deprecated, use "%s::create()" instead.', __METHOD__, __CLASS__); | ||
|
|
||
| if (false === strpos($string, '<')) { | ||
| return new self($string, ''); | ||
| } | ||
|
|
||
| if (!preg_match(self::FROM_STRING_PATTERN, $string, $matches)) { |
There was a problem hiding this comment.
Should we change this to call ::create instead of duplicating the logic ?
nicolas-grekas
approved these changes
Jun 9, 2020
fabpot
force-pushed
the
mailer-fromString-deprec
branch
from
f8783ff
to
6e28fda
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #37167