[Messenger] Fix precedence of DSN options for 4.4 #37268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
fix-precedence-44
branch
from
efd3b30
to
992205a
Compare
nicolas-grekas
approved these changes
Jun 14, 2020
kralos
reviewed
Jun 16, 2020
| @@ -209,7 +209,7 @@ public function buildConfigurationProvider(): iterable | |||
| 'expectedAutoSetup' => false, | |||
| ]; | |||
|
|
|||
| yield 'options from options array wins over options from dsn' => [ | |||
| yield 'options from dsn array wins over options from options' => [ | |||
There was a problem hiding this comment.
I think we should instead be referring to URI not DSN #36999 (comment)
especially in the context of messenger, this is not a data source.
There was a problem hiding this comment.
maybe, but this is not the purpose of this PR.
Dsn is consistent with the current code and documentation: https://symfony.com/doc/current/messenger.html#transports-async-queued-messages
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix précédence of DSN options over constructor options in all component on branch 4.4