[HttpFoundation] Allow null in InputBag@set
#37327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yceruto open against 5.1 here. |
|
The travis failure looks related, can you please have a look? |
|
@chalasr fixed that test. On Travis re-run the 7.3 branch is failing with a bunch of unrelated PDO failures. |
nicolas-grekas
approved these changes
Jun 17, 2020
|
Thank you @taylorotwell. And congratz for your first contribution to Symfony! :) |
|
Could we partially revert #37265 then? |
Merged
This was referenced Feb 26, 2021
Merged
fabpot
added a commit
that referenced
this pull request
Mar 12, 2021
…sademont) This PR was merged into the 5.3-dev branch. Discussion ---------- [HttpFoundation] Use InputBag for POST requests too | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Partially revert #37265 | License | MIT | Doc PR | - #37265 was created as a fix for #37100. However, when #37327 was merged, the original bug was also fixed with a different solution (allowing null values on `InputBag::set`) and parts of #37265 are not needed anymore. By using only `InputBag` as the `$request` bag we can tighten the typehint again and make static analysis a bit more useful. Commits ------- 381a0a1 use InputBag for POST requests too, added missing scalar type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
nullto be passed to InputBag'ssetmethod.Previously,
nullwas an allowed value to the InputBag'ssetmethod. At some point this was deprecated. It would be very nice for us to be able to set this tonull. For example, this ability drives a very popular feature of Laravel where we ship a middleware that converts all empty strings tonullon incoming requests.Note that the
getmethod already specifically allowsnullandnullis a valid decoded JSON value.