[PhpUnitBridge] fix handling the COMPOSER_BINARY env var when using simple-phpunit #41780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jun 22, 2021
nicolas-grekas
approved these changes
Jun 22, 2021
This change was somehow changed back during the renaming of the file I think. So this is just restoring the change.
Taluu
force-pushed
the
fix/phpunit-bridge-composer-binary-env
branch
from
8aae62d
to
9589b52
Compare
|
Note : Failures from fabbot are unrelated to the modification. Should I still apply them ? |
no need |
nicolas-grekas
changed the title
|
Thank you @Taluu. |
This was referenced Jun 30, 2021
Merged
Merged
Merged
This was referenced Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the renaming of the simple phpunit file (from the shebang to the php file) in #31364, it looks like the change made from #36566 was lost as it seems to have been merged after.
So this PR is an attempt to "restore" that functionnality, as it was considered a bug fix on 3.4 at the time.
poke @nicolas-grekas