Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security/Http] Fix cookie clearing on logout #44752

Merged
merged 1 commit into from Dec 22, 2021
Merged

[Security/Http] Fix cookie clearing on logout #44752

merged 1 commit into from Dec 22, 2021

Conversation

maxhelias
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

I think this was forgotten or a merge issue when the component was refactored :

@carsonbot carsonbot added this to the 5.4 milestone Dec 21, 2021
@maxhelias maxhelias force-pushed the security/samesite-cookie-clearer branch from 6c28928 to 8cef66e Compare December 21, 2021 15:30
@chalasr
Copy link
Member

chalasr commented Dec 21, 2021

Can you check if 5.3 is impacted?

@maxhelias
Copy link
Contributor Author

maxhelias commented Dec 21, 2021 •
edited

Yes, it is and since 5.1. I switch only in 5.3 ?

@chalasr
Copy link
Member

chalasr commented Dec 21, 2021

Please yes, it's the lowest maintained 5.x branch.

@maxhelias maxhelias force-pushed the security/samesite-cookie-clearer branch from 8cef66e to d1aa32a Compare December 21, 2021 16:45
@maxhelias maxhelias changed the base branch from 5.4 to 5.3 December 21, 2021 16:45
@maxhelias
Copy link
Contributor Author

@chalasr done ! 😉

@chalasr chalasr modified the milestones: 5.4, 5.3 Dec 21, 2021
@fabpot
Copy link
Member

fabpot commented Dec 22, 2021

Thank you @maxhelias.

@fabpot fabpot merged commit d3eeb83 into symfony:5.3 Dec 22, 2021
@maxhelias maxhelias deleted the security/samesite-cookie-clearer branch December 22, 2021 08:08
This was referenced Dec 29, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxhelias @chalasr @fabpot @carsonbot