[Form] Fix the usage of the Valid constraints in array-based forms #45702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
stof
force-pushed
the
fix_form_valid_constraints
branch
from
de1ebfc
to
542c2fb
Compare
yceruto
approved these changes
Mar 10, 2022
This was referenced Apr 2, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug introduced in #39333. When wanting to exclude scalar forms, it also excluded array forms.
The code now uses the same
\is_object($data) || \is_array($data)condition forValidconstraint than the condition it uses as part of the$validateDataGraphcondition.The new tests reflects my own use case: an unmapped collection field, were we want to run the validation on that subtree (which is not traversed for other reasons due to being unmapped, and so we need
Valid). This was working fine in older versions of Symfony, but the validation was silently skipped in 4.4.18+.