[HttpKernel] Remove EOL when using error_log() in HttpKernel Logger

[cyve]

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	maybe
Tickets
License	MIT
Doc PR

Hello there !

Since PR #36855, when using Symfony\Component\HttpKernel\Log\Logger with argument $output = null. The logger use the error_log() method to log messages. But in the log file, messages are separated by an empty line because the default formatter (Logger::format()) adds an extra EOL char at the end of the message.

This fix prevents the logger to add an extra EOL char when it uses error_log().

Possible BC : if someone use the logger with a custom formatter that already add a EOL char at the end of the message, there will be a empty line between messages in the log file. In my opinion, this is minor enough not to worry about it ;-)

Thanks for your review :-)

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[cyve]

Hi, I added a 2nd commit to apply coding standards on code that was not modified by the PR itself. Should I squash them ?

[nicolas-grekas]

Thank you @cyve.