Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Improve exception message in UnwrappingDenormalizer #49186

Merged
merged 1 commit into from
May 17, 2024

Conversation

andersonamuller
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The current code expects the path to be replaced in the message, but probably it was forgotten.

Copy link
Contributor

@alamirault alamirault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

I'm not sure, but I think it's considered as a bug and target must be 6.2 (was not on 5.4)

@alexislefebvre
Copy link
Contributor

It looks like this line wasn't tested so far.

If you have time, you can add a test that check this exception.

@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@xabbuh xabbuh modified the milestones: 7.1, 6.4 May 15, 2024
@carsonbot carsonbot changed the title Improve exception message in UnwrappingDenormalizer [Serializer] Improve exception message in UnwrappingDenormalizer May 15, 2024
@fabpot fabpot changed the base branch from 7.1 to 6.4 May 17, 2024 09:01
@fabpot
Copy link
Member

fabpot commented May 17, 2024

Thank you @andersonamuller.

@fabpot fabpot merged commit e4bd593 into symfony:6.4 May 17, 2024
7 of 10 checks passed
@fabpot fabpot mentioned this pull request May 17, 2024
This was referenced Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants