Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] fix XmlDumper when a tag contains also a 'name' property #54273

Merged
merged 1 commit into from Mar 14, 2024

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 13, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Since #47364, the tag can contain an array of attributes.
And since #47364, SF uses it to store workflow metadata and also a name property.
It likely broke the XML generation, and so it brokes debug:router command for instance.
Sorry, I didn't notice it before!

Before the patch, I got that in my container var/cache/dev/App_KernelDevDebugContainer.xml

<tag>workflow<attribute name="name">article</attribute><attribute name="metadata"><attribute name="title">Manage article</attribute></attribute></tag>

After, I got

<tag name="workflow">
  <attribute name="name">article</attribute>
  <attribute name="metadata">
    <attribute name="title">Manage article</attribute>
  </attribute>
</tag>

@stof
Copy link
Member

stof commented Mar 13, 2024

Actually, the PR you linked is not the one adding support for arrays in tag attributes (it is one that introduces a usage of such tag in the core).
Please identify the actual PR introducing that feature in the DI component, to identify the lowest affected branch.

@lyrixx lyrixx force-pushed the dic-dump-xml-tag-with-name branch from 23dcbbb to 0d38842 Compare March 13, 2024 16:18
@lyrixx lyrixx force-pushed the dic-dump-xml-tag-with-name branch from 0d38842 to 4a4b011 Compare March 13, 2024 16:24
@lyrixx lyrixx changed the base branch from 7.1 to 6.4 March 13, 2024 16:25
@lyrixx
Copy link
Member Author

lyrixx commented Mar 13, 2024

@stof I updated the PR description, the target branch (6.4), and fixed tests

@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit bf1ffd3 into symfony:6.4 Mar 14, 2024
9 of 10 checks passed
@lyrixx lyrixx deleted the dic-dump-xml-tag-with-name branch March 14, 2024 09:08
This was referenced Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants