Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] Enhance CoverageListenerTests #54283

Merged
merged 1 commit into from Mar 14, 2024

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 14, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

The test were broken on my laptop, so I dig it a bit and:

  • Add support support for pvoc
  • Change priority of driver, it's now xdebug > pcov > phpdbg (reflects
    more real usages)
  • Update deprecated phpunit.xml.dist configuration
  • Ensure the $output buffer is empty before running sub-tests
  • open php bug report because phpdbg segfault, see [phpdbg] Segfault with phpunit and codecoverage php/php-src#13707

@carsonbot

This comment was marked as resolved.

@lyrixx lyrixx force-pushed the phpunit-bridge-coverage-test branch from d928c0d to ae31f3b Compare March 14, 2024 07:56
* Add support support for pvoc
* Change priority of driver, it's now xdebug > pcov > phpdbg (reflects
  more real usages)
* Update deprecated phpunit.xml.dist configuration
* Ensure the $output buffer is empty before running sub-tests
@lyrixx lyrixx force-pushed the phpunit-bridge-coverage-test branch from ae31f3b to 4f49fd3 Compare March 14, 2024 09:05
@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit e49f84b into symfony:7.1 Mar 14, 2024
8 of 11 checks passed
@lyrixx lyrixx deleted the phpunit-bridge-coverage-test branch March 14, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants