[Form] Fix form value merging involving file upload, collection & checkbox #54324
Conversation
|
paging @nicolas-grekas |
priyadi
force-pushed
the
dev-fix-merge-options-form
branch
from
76fef46
to
fdc3e01
Compare
| @@ -30,8 +30,6 @@ private function __construct() | |||
| * a form and needs to be consistent. PHP keyword `empty` cannot | |||
| * be used as it also considers 0 and "0" to be empty. | |||
| * | |||
| * @param mixed $data | |||
There was a problem hiding this comment.
fabbot insists that I remove it. I reverted the changes, but it won't pass the test.
|
@nicolas-grekas bump. Is there anything else I need to do before this PR can be merged? |
| * | ||
| * @internal | ||
| */ | ||
| class ParamFilesMerger |
There was a problem hiding this comment.
Instead of introducing this new internal class the code should be moved into private methods in FormUtil as the class is only used there.
There was a problem hiding this comment.
The class represents a node in the tree. It is used by itself to traverse the entire tree. The task will be very complicated without a dedicated class.
There was a problem hiding this comment.
I have sent a PR against your fork which inlines the methods from the ParamFilesMerger class.
There was a problem hiding this comment.
I have merged your PR
priyadi
force-pushed
the
dev-fix-merge-options-form
branch
from
4a6078e
to
1cf2c5f
Compare
This is an update to the PR #53353
This fixes another value-files merging bug involving collections of a form containing a file upload field and a checkbox.