[Workflow] Add a way to add more definition validator #54398
+187
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
force-pushed
the
workflow-more-validator-2
branch
from
31e1344
to
1636505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked by @nicolas-grekas, I tried to use a cache warmer.
It works, but it has a huge drawback in term of DX:
I a throw an exception, or use
dd()in the validator, on the very fist time I see the exception, or thedd(), and If I refresh the page... the cache is hot, I see the homepage. This is not really handy to debug the warmer.More over, nothing prevent the application to boot 😬