[HttpClient] stop all server processes after tests have run #54400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
changed the title
xabbuh
force-pushed
the
http-client-tests-stop-server
branch
from
cd01164
to
36345e0
Compare
lyrixx
reviewed
Mar 27, 2024
fabpot
approved these changes
Apr 1, 2024
derrabus
reviewed
Apr 1, 2024
| @@ -52,7 +52,7 @@ | |||
| "minimum-stability": "dev", | |||
| "extra": { | |||
| "branch-alias": { | |||
| "dev-main": "2.5-dev" | |||
| "dev-main": "2.6-dev" | |||
There was a problem hiding this comment.
I wouldn't bump here. I think we can ship this as a bugfix.
|
Thank you @xabbuh. |
| @@ -25,7 +25,7 @@ | |||
| "php": ">=7.2.5", | |||
| "psr/log": "^1|^2|^3", | |||
| "symfony/deprecation-contracts": "^2.1|^3", | |||
| "symfony/http-client-contracts": "^2.4", | |||
| "symfony/http-client-contracts": "^2.6", | |||
There was a problem hiding this comment.
this should be updated to the next 2.4 I guess?
xabbuh
added a commit
that referenced
this pull request
Apr 1, 2024
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] fix contracts constraint | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT following #54400, a95835f and 9821d5c Commits ------- 8b4521a fix contracts constraint
This was referenced Apr 2, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spotted while working on #54388