[Finder] Also consider .git inside the basedir of in() directory

[nickvergessen]

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix described below
License	MIT

Bug description

Previously when the in() directory was the root of your repository the .gitignore was skipped from consideration, which meant potentially all local files are ignored.

E.g. in the Nextcloud community we have the server locally with an .gitignore for the apps/ directory. Now when an app developer develops their own app locally, they put their own git repository inside this ignored apps/ folder.
The CS Fixer rules we use since a long time are:

(new Finder())
	->ignoreVCSIgnored(true)
	->notPath('l10n')
	->notPath('vendor')
	->notPath('vendor-bin')
	->in(__DIR__);

and this worked pretty well with 5.4 and previous versions of the finder. Now that the Nextcloud project finally dropped PHP 8.0 for the latest version and we get the update to Symfony 6.4 the bug become visible locally, but our CI still works as we don't need the "server" repository as a parent when running the CS fixer.

Locally - nested inside "server" repository

~/Nextcloud/server/apps/spreed$ composer run cs:check
> php-cs-fixer fix --dry-run --diff
PHP CS Fixer 3.54.0 15 Keys Accelerate by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 8.2.18
Loaded config default from "/home/nickv/Nextcloud/30/server/appsbabies/spreed/.php-cs-fixer.dist.php".
Using cache file ".php-cs-fixer.cache".
    0 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]

❌ No files found, all ignored by server/.gitignore

CI without a parent repository

Run composer run cs:check || ( echo 'Please run `composer run cs:fix` to format your code' && exit 1 )
 > php-cs-fixer fix --dry-run --diff
PHP CS Fixer 3.54.0 15 Keys Accelerate by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 8.1.2-1ubuntu2.13
Loaded config default from "/home/runner/actions-runner/_work/spreed/spreed/.php-cs-fixer.dist.php".
   0/502 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%

✅ Correct file list found

5.4

• From my POV this is a regression from [Finder] Look for gitignore patterns up to git root #43239 (so 6.1+ only) and it becomes more "obvious" when backporting the unit test to 5.4 as it passes there without patching VcsIgnoredFilterIterator.php.
• Therefore cc-ing @julienfalque as author, to clarify if this was intentional

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[julienfalque]

Nope, this was not intentional.

[fabpot]

Thank you @nickvergessen.