Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier] Add Primotexto bridge #54747

Open
wants to merge 1 commit into
base: 7.1
Choose a base branch
from

Conversation

Goazil
Copy link

@Goazil Goazil commented Apr 26, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues none
License MIT

This PR adds a new bridge for Primotexto. Based on documentation available here: https://www.primotexto.com/

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@Goazil Goazil force-pushed the feature/primotexto-notifier branch 5 times, most recently from aff8a2d to 851b363 Compare April 26, 2024 13:52
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update UnsupportedSchemeException and UnsupportedSchemeExceptionTest, thanks

@Goazil Goazil force-pushed the feature/primotexto-notifier branch 3 times, most recently from 4af85a9 to 1ded74a Compare April 26, 2024 15:23
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your committer email is not associated with your GitHub account

@OskarStark OskarStark modified the milestones: 7.1, 7.2 Apr 28, 2024
@Goazil Goazil force-pushed the feature/primotexto-notifier branch from 1ded74a to d05a445 Compare April 29, 2024 06:54
@Goazil
Copy link
Author

Goazil commented Apr 29, 2024

Thanks for the review @OskarStark, I hope it's okay now :)

@Goazil Goazil force-pushed the feature/primotexto-notifier branch from d05a445 to 2013821 Compare April 29, 2024 06:58
@OskarStark
Copy link
Contributor

Can be merged into 7.2 if available

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my last small comment.

In the meantime you can please create a PR against symfony/symfony-docs and symfony/recipes repo, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants