[DependencyInjection] Add tagged_variadic tag
#54749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fan2Shrek
force-pushed
the
feat/tagged_iterator
branch
3 times, most recently
from
516f1cd
to
73eae20
Compare
Fan2Shrek
changed the title
Fan2Shrek
changed the title
OskarStark
changed the title
tagged_variadic tag
OskarStark
reviewed
Apr 28, 2024
src/Symfony/Component/DependencyInjection/Argument/TaggedVariadicArgument.php
Outdated
Show resolved
Hide resolved
Fan2Shrek
force-pushed
the
feat/tagged_iterator
branch
from
73eae20
to
06e3a02
Compare
|
Closing as explained in #54741 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
tagged_variadicvery similar to thetagged_iteratorexcept he takes advantage of the variadic parameters.See #54741 example
I'm not sur if extending
TaggedIteratorArgumentis the best approachThanks to the people who are going to take time to review this ♥