Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Autocomplete] Adding morph support for Turbo & overhauling process #1512

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

weaverryan
Copy link
Member

Q A
Bug fix? yes
New feature? yes
Issues Fix #1500
License MIT

This is WIP. The goal is to, during morphing, do both of the following:

  1. Prevent morphing from removing any manual DOM changes made by TomSelect (which we want to keep)
  2. Notice any changes (e.g. the underlying <option> elements change) that would require a TomSelect "reset" and doing that reset.

There are lot of permutations to get right, especially with (2), like making sure that both single & multiple <select> work as well as TomSelect used on an <input>.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Work Additional work is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Autocomplete][LiveComponent] Select box doesn't reset when used in a live component
2 participants