minor #400 Use a different priority for each plugin (Lyrkan)

symfony · Oct 10, 2018 · d8093ad · d8093ad
2 parents c5ae324 + 3c519e3
commit d8093ad
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 19 deletions.
diff --git a/lib/plugins/entry-files-manifest.js b/lib/plugins/entry-files-manifest.js
@@ -29,6 +29,6 @@ module.exports = function(plugins, webpackConfig) {
             [sharedEntryTmpName],
             webpackConfig.styleEntries
         ),
-        priority: PluginPriorities.DeleteUnusedEntriesJSPlugin
+        priority: PluginPriorities.EntryFilesManifestPlugin
     });
 };
diff --git a/lib/plugins/plugin-priorities.js b/lib/plugins/plugin-priorities.js
@@ -10,20 +10,20 @@
 'use strict';
 
 module.exports = {
-    MiniCssExtractPlugin: 0,
-    DeleteUnusedEntriesJSPlugin: 0,
-    WebpackManifestPlugin: 0,
-    SharedEntryContactPlugin: 0,
-    LoaderOptionsPlugin: 0,
-    ProvidePlugin: 0,
-    CleanWebpackPlugin: 0,
-    DefinePlugin: 0,
-    FriendlyErrorsWebpackPlugin: 0,
-    AssetOutputDisplayPlugin: 0,
-    ForkTsCheckerWebpackPlugin: 0,
+    MiniCssExtractPlugin: 140,
+    DeleteUnusedEntriesJSPlugin: 130,
+    WebpackManifestPlugin: 120,
+    LoaderOptionsPlugin: 110,
+    WebpackChunkHash: 100,
+    ProvidePlugin: 90,
+    CleanWebpackPlugin: 80,
+    DefinePlugin: 70,
+    WebpackNotifier: 60,
+    VueLoaderPlugin: 50,
+    FriendlyErrorsWebpackPlugin: 40,
+    AssetOutputDisplayPlugin: 30,
+    SharedEntryContactPlugin: 20,
+    ForkTsCheckerWebpackPlugin: 10,
     HashedModuleIdsPlugin: 0,
-    WebpackChunkHash: 0,
-    WebpackNotifier: 0,
-    VueLoaderPlugin: 0,
     EntryFilesManifestPlugin: -10,
 };
diff --git a/test/config-generator.js b/test/config-generator.js
@@ -592,7 +592,7 @@ describe('The config-generator function', () => {
             expect(ignorePlugin).to.not.be.undefined;
         });
 
-        it('by default custom plugins are added at the end and are kept in order', () => {
+        it('by default custom plugins are added after the last plugin with a priority of 0 and are kept in order', () => {
             const config = createConfig();
             config.outputPath = '/tmp/public/build';
             config.setPublicPath('/build/');
@@ -603,9 +603,9 @@ describe('The config-generator function', () => {
             const actualConfig = configGenerator(config);
             const plugins = actualConfig.plugins;
 
-            expect(plugins[plugins.length - 3]).to.be.instanceof(CustomPlugin1);
-            expect(plugins[plugins.length - 2]).to.be.instanceof(CustomPlugin2);
-            expect(plugins[plugins.length - 1]).to.be.instanceof(CustomPlugin3);
+            expect(plugins[plugins.length - 4]).to.be.instanceof(CustomPlugin1);
+            expect(plugins[plugins.length - 3]).to.be.instanceof(CustomPlugin2);
+            expect(plugins[plugins.length - 2]).to.be.instanceof(CustomPlugin3);
         });
 
         it('plugins can be sorted relatively to each other', () => {