Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility between mini-css-extract-plugin 0.4.3 and the manifest plugin #404

Closed
Lyrkan opened this issue Oct 7, 2018 · 1 comment
Labels
Bug Bug Fix

Comments

@Lyrkan
Copy link
Collaborator

Lyrkan commented Oct 7, 2018

While working on #403 I noticed that the build was failing when upgrading all of our dependencies to their latest allowed version.

It seems that this is caused by an incompatibility between mini-css-extract-plugin@0.4.3 and webpack-manifest-plugin: webpack-contrib/mini-css-extract-plugin#177 (comment)

I opened an issue on the Webpack Manifest Plugin repository (shellscape/webpack-manifest-plugin#167), but meanwhile maybe we should force mini-css-extract-plugin to use v0.4.2?

@Lyrkan Lyrkan added the Bug Bug Fix label Oct 7, 2018
weaverryan added a commit that referenced this issue Oct 18, 2018
…. allowed Webpack version (Lyrkan)

This PR was merged into the master branch.

Discussion
----------

Fix the mini-css-extract-plugin 0.4.3 issue and increase min. allowed Webpack version

This PR fixes both of the issues detected in #403:

- Set the maximum allowed version for `mini-css-extract-plugin` to 0.4.2 (since 0.4.3 doesn't work with the current version of the webpack-manifest-plugin, see #404). This is a temporary solution, once it's fixed (either in mini-css-extract-plugin or in weback-manifest-plugin) we'll have to change it again.

- Set the minimum allowed version for `webpack` to 4.20.0. The previous one (4.0.0) seemed to break `mini-css-extract-plugin` (see https://travis-ci.org/Lyrkan/webpack-encore/jobs/439810002).

Commits
-------

04f42af Temporary fix for the mini-css-extract-plugin 0.4.3 issue
@Lyrkan
Copy link
Collaborator Author

Lyrkan commented Feb 23, 2019

Duplicate of #415

@Lyrkan Lyrkan marked this as a duplicate of #415 Feb 23, 2019
@Lyrkan Lyrkan closed this as completed Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix
Projects
None yet
Development

No branches or pull requests

1 participant