Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mini-css-extract-plugin 0.4.3 issue and increase min. allowed Webpack version #406

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Lyrkan
Copy link
Collaborator

@Lyrkan Lyrkan commented Oct 10, 2018

This PR fixes both of the issues detected in #403:

@Lyrkan
Copy link
Collaborator Author

Lyrkan commented Oct 10, 2018

By the way, once we update mini-css-extract-plugin to 0.4.4+ we'll also have to change some of the tests related to versioning due to this commit (hashes not being the same anymore).

@weaverryan
Copy link
Member

Looks like a bit of a mess with mini-css-extract. 0.4.4 is now out. Does it fix the issue, or does the issue remain? Another way of asking this is: will the issue be fixed in mini-css, or is their opinion that this is not a bug, and it should be fixed elsewhere?

@Lyrkan
Copy link
Collaborator Author

Lyrkan commented Oct 17, 2018

Does it fix the issue, or does the issue remain?

That's still an issue when using 0.4.4: https://travis-ci.org/symfony/webpack-encore/jobs/439825872#L1055

The only different thing with 0.4.4 is that more tests are failing because it changes how some hashes are generated.

will the issue be fixed in mini-css, or is their opinion that this is not a bug, and it should be fixed elsewhere?

Based on the last comments here I'm not sure that there is an issue with mini-css-extract-plugin.

@weaverryan weaverryan merged commit 04f42af into symfony:master Oct 18, 2018
weaverryan added a commit that referenced this pull request Oct 18, 2018
…. allowed Webpack version (Lyrkan)

This PR was merged into the master branch.

Discussion
----------

Fix the mini-css-extract-plugin 0.4.3 issue and increase min. allowed Webpack version

This PR fixes both of the issues detected in #403:

- Set the maximum allowed version for `mini-css-extract-plugin` to 0.4.2 (since 0.4.3 doesn't work with the current version of the webpack-manifest-plugin, see #404). This is a temporary solution, once it's fixed (either in mini-css-extract-plugin or in weback-manifest-plugin) we'll have to change it again.

- Set the minimum allowed version for `webpack` to 4.20.0. The previous one (4.0.0) seemed to break `mini-css-extract-plugin` (see https://travis-ci.org/Lyrkan/webpack-encore/jobs/439810002).

Commits
-------

04f42af Temporary fix for the mini-css-extract-plugin 0.4.3 issue
@weaverryan
Copy link
Member

Hmm ok. Obviously, this is far from ideal :). I created #415 to track this. My guess is that we're going to need to go into the manifest plugin ourselves and submit a PR to fix this - I noticed one +1 on it, but no feedback :/

Anyways, thanks! This fixes our immediate problem - which is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants