New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyodide test to CI #23542
Add pyodide test to CI #23542
Conversation
✅ Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
🟠Hi, I am the SymPy bot (v167). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
47ba142
to
bc17ecb
Compare
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[77f1d79c] [58727537]
<sympy-1.10.1^0>
+ 124±2ms 230±5ms 1.85 sum.TimeSum.time_doit
Full benchmark results can be found as artifacts in GitHub Actions |
This looks good to me. If Oscar's concerns about the runtime were addressed we can merge. |
The runtime is improved but this is still just about the last job to finish. Maybe it could be improved by updating the splits. Is it possible to install gmpy2 in pyiodide? That might speed it up. In any case it is impressive how fast it runs. If we can't use gmpy2 there than I think this is good to merge. |
gmpy2 is not pure python package, so it should be explicitly built for wasm and added to https://github.com/pyodide/pyodide/tree/main/packages. I use pyodide a lot but haven't tried building a package. I can try in the future though I expect it non-trivial. |
Okay, let's merge this. I am a bit concerned that our CI just seems to be getting bigger and more complicated though... |
I built gmpy2 and opened pyodide/pyodide#2665. |
References to other Issues or PRs
Closes #23529
Brief description of what is fixed or changed
Ideally, testing pyodide using selenium is more close to real use case. However, selenium's doc is too hard to understand, and it involves many browser-specific things. Moreover, full coverage requires testing on Safari, Firefox and Chromium as they have different kernel. I believe that's not what we aim to.
As pyodide supports node recently, we can test sympy on it. That's a lot easier than testing on selenium (yes I tried and gave up because I failed to capture console log as testing on bash with CPython).
Other comments
Release Notes
NO ENTRY