Make physics.mechanics.wrapping_geometry public
#25510
Conversation
|
✅ Hi, I am the SymPy bot (v170). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
moorepants
added
CZI: Codegen/Biomech
|
|
The decision behind calling it just I think it still belongs in |
🟠Hi, I am the SymPy bot (v170). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
moorepants
changed the title
moorepants
changed the title
Yes, I agree that the base classes should be public and in the main module namespace. |
|
Getting these new docs errors: Need to make explicit references to these points. EDIT : Seems that this is tied to the type annotations that use |
|
Similar issue about the warning: sphinx-doc/sphinx#10400 |
|
May also be related: sphinx-doc/sphinx#4961 |
|
I tried something like: and then in type annotation use |
|
The type annotations cause these types of warnings when using autodoc and numpydoc with Sphinx: These are just warnings, but it automatically selects the first object with a matching name that it finds and then makes a hyperlink to the object, in some cases to the incorrect object. It would be nice if we could disable hyperlink generation if the choice of objects is ambiguous. It isn't clear why it doesn't select the correct objects given that it has access to the actual object. Seems like a sphinx/autodoc/numpydoc bug. |
|
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[8059df73] [77010f3b]
<sympy-1.12^0>
- 95.9±3ms 62.4±0.7ms 0.65 integrate.TimeIntegrationRisch02.time_doit(10)
- 95.8±2ms 63.8±1ms 0.67 integrate.TimeIntegrationRisch02.time_doit_risch(10)
- 2.38±0.07ms 710±60μs 0.30 polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse')
- 11.4±0.1ms 1.98±0.01ms 0.17 polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse')
- 371±3μs 84.4±4μs 0.23 polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse')
- 5.51±0.1ms 371±2μs 0.07 polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse')
- 12.1±0.2ms 1.12±0.01ms 0.09 polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse')
- 6.55±0.04ms 4.05±0.06ms 0.62 polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse')
- 28.7±0.7ms 12.2±0.1ms 0.42 polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse')
- 7.04±0.1ms 1.21±0.01ms 0.17 polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse')
- 16.3±0.1ms 9.29±0.05ms 0.57 polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse')
- 226±3ms 71.6±0.3ms 0.32 polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse')
- 7.18±0.09ms 579±5μs 0.08 polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse')
- 30.7±0.2ms 901±20μs 0.03 polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse')
- 646±9μs 224±3μs 0.35 polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse')
- 7.24±0.06ms 226±2μs 0.03 polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse')
- 19.1±0.4ms 234±2μs 0.01 polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse')
- 186±2μs 102±0.8μs 0.55 solve.TimeMatrixOperations.time_rref(3, 0)
- 345±4μs 127±4μs 0.37 solve.TimeMatrixOperations.time_rref(4, 0)
- 34.0±0.7ms 14.5±0.06ms 0.43 solve.TimeSolveLinSys189x49.time_solve_lin_sys
Full benchmark results can be found as artifacts in GitHub Actions |
…incorrect equation for cylinder.
|
I removed all type hints in geometry because of the sphinx hyperlink bug. Couldn't find another way to fix it. |
brocksam
changed the title
physics.mechanics.wrapping_geometry public
I think the problem is the use of |
|
@oscarbenjamin thanks for the clue. |
References to other Issues or PRs
Original PR: #25068
Brief description of what is fixed or changed
Makes
sympy.physics.mechanics.wrapping_geometrypublic and improves documentation.Other comments
Release Notes