lib/model: Don't bump seq on error in index handler (#9459)

syncthing · Mar 11, 2024 · 8c8167a · 8c8167a
1 parent 73cc555
commit 8c8167a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/model/indexhandler.go b/lib/model/indexhandler.go
@@ -293,7 +293,9 @@ func (s *indexHandler) sendIndexTo(ctx context.Context, fset *db.FileSet) error
 		return err
 	}
 
-	err = batch.Flush()
+	if err := batch.Flush(); err != nil {
+		return err
+	}
 
 	// Use the sequence of the snapshot we iterated as a starting point for the
 	// next run. Previously we used the sequence of the last file we sent,
@@ -302,7 +304,7 @@ func (s *indexHandler) sendIndexTo(ctx context.Context, fset *db.FileSet) error
 	// reverted). No point trying to send nothing again.
 	s.prevSequence = snap.Sequence(protocol.LocalDeviceID)
 
-	return err
+	return nil
 }
 
 func (s *indexHandler) receive(fs []protocol.FileInfo, update bool, op string) error {