Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(registry-scanner): add support for ocp registry #1711

Merged
merged 5 commits into from
May 28, 2024
Merged

feat(registry-scanner): add support for ocp registry #1711

merged 5 commits into from
May 28, 2024

Conversation

mech-pig
Copy link
Contributor

@mech-pig mech-pig commented Apr 24, 2024 •
edited by hayk99

What this PR does / why we need it:

This PR adds the necessary changes to support Openshift registries in the registry scanner.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@mech-pig mech-pig requested review from a team as code owners April 24, 2024 14:10
@mech-pig mech-pig force-pushed the ma/vm/registry-scanner/feat/add-support-for-internal-ocp-registry branch 6 times, most recently from c0c3b4b to 88b357a Compare April 29, 2024 09:13
@mech-pig mech-pig force-pushed the ma/vm/registry-scanner/feat/add-support-for-internal-ocp-registry branch 2 times, most recently from d56d6f8 to 389080b Compare April 29, 2024 09:37
@mech-pig mech-pig force-pushed the ma/vm/registry-scanner/feat/add-support-for-internal-ocp-registry branch from 389080b to b27e11e Compare April 29, 2024 09:40
@maratsal maratsal mentioned this pull request May 10, 2024
Closed
5 tasks
@mech-pig mech-pig marked this pull request as draft May 10, 2024 21:29
@hayk99 hayk99 self-assigned this May 28, 2024
@hayk99 hayk99 marked this pull request as ready for review May 28, 2024 13:46
@hayk99 hayk99 merged commit bf5495f into main May 28, 2024
5 checks passed
@hayk99 hayk99 deleted the ma/vm/registry-scanner/feat/add-support-for-internal-ocp-registry branch May 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayk99 hayk99 hayk99 approved these changes

Assignees

@hayk99 hayk99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mech-pig @hayk99