feat(agent): add support for Windows Agent #1730
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort-for-windows-agent
AlbertoBarba
reviewed
May 6, 2024
| {{- else }} | ||
| secretName: {{ include "agent.accessKeySecret" . }} | ||
| {{- end }} | ||
| nodeSelector: |
There was a problem hiding this comment.
@iurly would it make sense to add
"kubernetes.io/os": linuxin:
- charts/agent/templates/daemonset.yaml
- charts/agent/templates/deployment.yaml
?
…ort-for-windows-agent
- introduce windows top-level object with all settings - fix agent-windows.* helpers - add serviceAccountName (same as linux) - fix handling of windows.image.registry - move nodeSelector from windowsDaemonset. to windows. - add windows.affinity and windows.tolerations - add windows.resources - use windows.image.tag as app.kubernetes.io/version
…ort-for-windows-agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is draft/WIP PR to add support for the Windows Agent
Please note:
dragent.yaml) to allow testing, pending changes to the agent's code (see SSPROD-39123). THIS CHANGE SHOULD NOT BE MERGEDvalues.yamlChecklist
feat(agent,node-analyzer,sysdig-deploy):)