Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACPI methods for setting fan speed #143

Open
wants to merge 21 commits into
base: system76
Choose a base branch
from
Open

Add ACPI methods for setting fan speed #143

wants to merge 21 commits into from

Conversation

curiousercreative
Copy link

@curiousercreative curiousercreative commented Oct 17, 2022 •
edited

@curiousercreative curiousercreative marked this pull request as ready for review October 17, 2022 17:15
This was referenced Oct 17, 2022
Open
Open
Open
@curiousercreative curiousercreative mentioned this pull request Oct 18, 2022
Open
@crawfxrd crawfxrd requested review from jackpot51 and a team January 19, 2023 16:24
@curiousercreative curiousercreative force-pushed the acpi-fans branch 2 times, most recently from 2c2f6ac to 3d53ebc Compare June 9, 2023 04:28
@MilesBHuff
Copy link

@jackpot51 This has been open a while; do you have an idea when it might be merged? This would be a great feature to have, and is widely desired if the number of thumbs on the following issues are any indication: pop-os/system76-acpi-dkms/issues/9 and system76/ec#213.

@curiousercreative curiousercreative changed the base branch from system76 to master July 10, 2023 20:52
@curiousercreative curiousercreative changed the base branch from master to system76 July 10, 2023 20:52
@curiousercreative
Copy link
Author

curiousercreative commented Jul 10, 2023 •
edited

freshly rebased and tested on my galp5

crawfxrd and others added 9 commits November 19, 2023 22:05
@crawfxrd
submodules: Use absolute paths
9fa04e1 
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Change-Id: If03415f80a6028e263e76a9e3cc10df0cde5cc3c
@jackpot51 @crawfxrd
intel/block/pcie/rtd3: ACPI debug messages
5f3df49 
Change-Id: Icc4a882ff73f62a134b92f1afb0dc298ea809189
Signed-off-by: Jeremy Soller <jeremy@system76.com>
@jackpot51 @crawfxrd
intel/block/pcie/rtd3: Also implement _PR3
ea848eb 
Change-Id: Id7f4373989dffe8c3bc68a034f59a94d2160dd15
Signed-off-by: Jeremy Soller <jeremy@system76.com>
@crawfxrd
security/tpm/tspi: Do TPM Restart if TPM Resume fails
d9977a9 
The Infineon SLB 9672 on newer Clevo machines regularly fails TPM Resume
on S3 with the error `TPM_RC_VALUE`.

Per TPM2 spec, handle the failure by performing a TPM Restart.

> The startup behavior defined by this specification is different than
> TPM 1.2 with respect to Startup(STATE). A TPM 1.2 device will enter
> Failure Mode if no state is available when the TPM receives
> Startup(STATE). This is not the case in this specification. It is up
> to the CRTM to take corrective action if it the TPM returns
> TPM_RC_VALUE in response to Startup(STATE).

Fixes the following error from being repeatedly logged in Linux:

> kernel: tpm tpm0: A TPM error (256) occurred attempting get random

Ref: Trusted Platform Module Library, Part 1: Architecture, rev 1.59
Change-Id: I3388007d4448c93bd0dda591c8ca7d1a8dc5306b
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@mkopec @crawfxrd
drivers/smmstore/ramstage.c: retry smmstore init up 5 times
5f608c9 
Retry calling the SMI 5 times in case the initial write to APM did not
cause SMM entry immediately.

Fixes occasional SMMSTORE initialization failure on Clevo NV4xPZ with
Intel i5-1240P processor. The issue was especially evident when all
logging in coreboot was disabled.

Based on SMMSTORE implementation in MrChromebox's fork of EDK2:
MrChromebox/edk2@27854bc

Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
@jackpot51 @crawfxrd
soc/intel/alderlake: Hack to preserve SBREG
e312861 
Change-Id: Ie70905d34a4050aeff4b5cda116eb700f19a18ea
@mravindr @crawfxrd
soc/common/smbus: Add support for reading spd data via smbus for DDR5
8289350 
DDR5 uses a Serial Presence Detect EEPROM with hub function
(SPD5 hub device) to store the spd data.
This CL adds support to read the spd5 hub device via smbus.

BUG=b:180458099
TEST=Boot adlrvp DDR5 board to kernel

Signed-off-by: Meera Ravindranath <meera.ravindranath@intel.com>
Change-Id: Ic5e6c58f255bef86b68ce90a4f853bf4e7c7ccfe
@jackpot51 @crawfxrd
soc/intel/adl: Fill in SPD data on both channels of DDR5 memory
7fcf710 
CB:52731 introduced support for reading SPD from the EEPROM via SMBus.
Replace the now unneeded workaround for DDR5 with filling in the correct
channels for DDR5.

Change-Id: I5a92199a7cd2718e9396f0dac8257df40e4f834c
Signed-off-by: Jeremy Soller <jeremy@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@jackpot51 @crawfxrd
lib,soc/intel/common/block/smbus: Use a SPD length of 512 bytes for DDR5
3289a30 
Change-Id: I8bdc4c676a0f571fd8f34e078f6a1c73a2e90a87
Signed-off-by: Jeremy Soller <jeremy@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51 and others added 11 commits November 19, 2023 22:05
@jackpot51 @crawfxrd
drivers/intel/dtbt: Add discrete Thunderbolt driver
fa90e35 
Add a new driver for discrete Thunderbolt controllers. This allows using
Maple Ridge devices on Raptor Point PCH.

Change-Id: Ib78ce43740956fa2c93b9ebddb0eeb319dcc0364
Signed-off-by: Jeremy Soller <jeremy@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
mb/system76/rpl: Enable discrete TBT device
dca78e4 
The HX board, using PCH-S, use a discrete Thunderbolt device (Intel
Maple Ridge), as opposed to a built-in one like the boards using PCH-P.

Fixes Thunderbolt on RPL-HX boards using the Maple Ridge controller.

Change-Id: I53d18f3ec5a084431e1113782c791bcb42728350
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
mb/system76/bonw14: Enable TAS5825M smart amp
c93689d 
The Bonobo has 2 AMPs: one for the speakers and one for the subwoofer.

Smart AMP data was collected using a logic analyzer connected to the IC
during system start on proprietary firmware. This data is then used to
generate a C file [1].

[1]: https://github.com/system76/smart-amp

Change-Id: I5389a9890563ebd3adb20096b6225f474bc006f9
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
soc/intel/alderlake: Add IRQ for non-existent CPU PCIe device
f97ffca 
Device 0:01.1 does not exist on ADL-P. I assume this works because the
bridged device has function 1.

Fixes the following error in Linux:

    pcieport 0000:00:01.0: can't derive routing for PCI INT B
    snd_hda_intel 0000:01:00.1: PCI INT B: no GSI - using ISA IRQ 10

Which in turn resolves the conflict with the PCH HDA device...again:

    irq 10: nobody cared (try booting with the "irqpoll" option)
    <snip>
    [<00000000bf549647>] azx_interrupt [snd_hda_codec]
    Disabling IRQ system76#10

Change-Id: I9d9a0003764a1e031be578c1f406b2a5d7512de7
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@jackpot51 @crawfxrd
drivers/gfx/nvidia: Add driver for NVIDIA GPU
1cf2970 
Add a driver for laptops with NVIDIA Optimus (hybrid) graphics. The
driver provides ACPI support for dynamically powering on and off the
GPU, NVIDIA Dynamic Boost support, and a function for enabling the GPU
power in romstage.

References:
- DG-09845-001: NVIDIA GN20/QN20 Hardware Design Guide
- DG-09954-001: NVIDIA GN20/QN20 Software Design Guide

Change-Id: I2dec7aa2c8db7994f78a7cc1220502676e248465
Signed-off-by: Jeremy Soller <jeremy@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
mb/system76: Enable dGPUs
8270aee 
Change-Id: I28fe45afaccd60621f2f2456af14306e18df2657
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
ec/system76: Support lockdown based on EC security state
2f5e317 
Change-Id: I202c0607c2cdac1df59f42fb41735704dd5bd95c
Signed-off-by: Jeremy Soller <jeremy@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
mb/system76: Enable EC lockdown on TGL+
1a5bdc5 
Change-Id: I4b07846c404eb93ab4baf0a78a4bbffcc5d8afca
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
mb/system76: Enable S0ix for darp8/darp9
09bdd1e 
The newer batch of these boards do not de-assert VW PLTRST# on S3
resume, causes the units to not power on in the EC code. Switch them to
S0ix by default, but leave S3 available.

Change-Id: I95337c1391102db9e020e82bdd938659c1a4f905
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
mb/system76: Add custom CMOS default for darp8,darp9
cd9cf8b 
Since these boards will use S0ix they need to leave CSME enabled for the
CPU to reach C10.

Change-Id: I70c908402c9964508bb9c439d48d24773f5a35ab
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
mb/system76/rpl: darp9: Add SSD RTD3 configs
02221a3 
Some drives block the CPU from reaching C10 on suspend without the RTD3
config.

Fixes suspend with the following drives:

- Kingston KC3000 (SKC3000D/4096G)
- Kingston HyperX (SHPM2280P2H/240G)
- Solidigm P44 Pro (SSDPFKKW010X7)

The following drives continue to work:

- Samsung 970 Evo (MZVLB250HAHQ)
- WD Black SN770 (WDS250G3X0E)
- WD Green SN350 (WDS240G2G0C-00AJM0)
- WD Blue SN570 (WDS100T3B0C)

Change-Id: I205d78377fa2b0db8d37542cdb94ba86ded1d66e
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Tested-by: Levi Portenier <levi@system76.com>
@curiousercreative curiousercreative changed the base branch from system76 to main January 24, 2024 15:40
@curiousercreative curiousercreative changed the base branch from main to system76 January 24, 2024 15:40
@curiousercreative
add ACPI methods for setting fan speeds
2823ddd 
Change-Id: Ib6548c571de300cec476f06f526d4c032e438f34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 Awaiting requested review from jackpot51

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@curiousercreative @MilesBHuff @crawfxrd @jackpot51 @mkopec @mravindr