power: Handle signals in separate functions #386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
crawfxrd
commented
Jul 24, 2023
|
|
||
| void power_event(void) { | ||
| const bool ac_new = power_handle_acin_n(); | ||
| gpio_set(&AC_PRESENT, !ac_new); |
There was a problem hiding this comment.
Does it need to be set on every cycle, or can it be set only when ACIN# changes?
crawfxrd
commented
Jul 24, 2023
| // Read power switch state | ||
| const bool ps_new = power_handle_pwr_sw_n(); | ||
| // Send power signal to PCH | ||
| gpio_set(&PWR_BTN_N, ps_new); |
There was a problem hiding this comment.
Does it need to be set on every cycle, or can it be set only when PWR_SW# changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break up
power_eventinto functions for handling each signal.This reduces complexity of the
power_eventfunction itself and brings it down to <100 LoC.