Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fan: Add fan-off hysteresis value #460

Closed
wants to merge 1 commit into from
Closed

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented May 13, 2024

Add a hysteresis for fan-off to prevent fans from constantly starting/stopping when the system temperature hovers at the minimum fan table value.

Note: 2°C was arbitrarily chosen.

TODO:

  • Track when it cooling to know when to apply hyteresis

Test:

  • Configure fan points to start near temperature when system is idle, I guess
  • Observe frequency of fans starting and stopping

Ref: system76/firmware-open#250

Add a hysteresis for fan-off to prevent fans from constantly
starting/stopping when the system temperature hovers at the minimum fan
table value.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd marked this pull request as ready for review May 13, 2024 20:12
@crawfxrd crawfxrd requested review from a team May 13, 2024 20:12
@crawfxrd crawfxrd marked this pull request as draft May 14, 2024 15:16
@crawfxrd crawfxrd closed this May 31, 2024
@crawfxrd crawfxrd deleted the fan-off-hysteresis branch May 31, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant