hostnamed: exit-on-idle tweaks #32720
Open
+123
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns are still ongoing And while we are at it, ongoing PK authorizations are also a reason to block exit on idle.
…r a service is idle
github-actions
bot
added
documentation
build-system
meson
please-review
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
bluca
reviewed
May 8, 2024
| _public_ int sd_bus_pending_method_calls(sd_bus *bus) { | ||
|
|
||
| /* Returns the number of currently pending asynchronous method calls. This is graceful, i.e. an | ||
| * unallocate (i.e. NULL) bus connection has no method calls pending. */ |
bluca
reviewed
May 8, 2024
| if (!bus) | ||
| return 0; | ||
|
|
||
| assert_return(bus, -EINVAL); |
There was a problem hiding this comment.
this is redundant with the check above
bluca
reviewed
May 8, 2024
bluca
approved these changes
May 8, 2024
bluca
added
good-to-merge/with-minor-suggestions
and removed
please-review
YHNdnzj
approved these changes
May 8, 2024
| <refnamediv> | ||
| <refname>sd_bus_pending_method_calls</refname> | ||
|
|
||
| <refpurpose>Return number of currently pending, outgoing method calls</refpurpose> |
There was a problem hiding this comment.
Suggested change
| <refpurpose>Return number of currently pending, outgoing method calls</refpurpose> | |
| <refpurpose>Return the number of currently pending, outgoing method calls</refpurpose> |
yuwata
approved these changes
May 10, 2024
|
i guess we should do this for v257. While the current behaviour of exiting on idle even if polkit authentication is still pending is mildly buggy it also doesn't really matter, the time window should be too small. Moreover this probably needs fixing in more than just hostnamed, hence this is kinda incomplete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.