Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-network: workaround for netdevsim bug #32927

Merged
merged 3 commits into from
May 20, 2024
Merged

test-network: workaround for netdevsim bug #32927

merged 3 commits into from
May 20, 2024

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented May 19, 2024 •
edited by github-actions bot

Workaround for #32910 caused by torvalds/linux@8debcf5.

@yuwata yuwata added the tests label May 19, 2024
@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label May 19, 2024
@github-actions GitHub Actions

This comment was marked as off-topic.

Sign in to view
@yuwata yuwata linked an issue May 19, 2024 that may be closed by this pull request
TEST-85-NETWORK-NetworkdSRIOVTests failed in GitHub Actions #32910
Closed
@yuwata yuwata added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed please-review PR is ready for (re-)review by a maintainer labels May 19, 2024
@yuwata yuwata marked this pull request as draft May 19, 2024 20:27
@yuwata yuwata changed the title test-network: wait for bind event for netdevsim device before creating ports test-network: workaround for netdevsim bug May 20, 2024
@yuwata yuwata marked this pull request as ready for review May 20, 2024 00:57
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels May 20, 2024
@bluca bluca added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed please-review PR is ready for (re-)review by a maintainer labels May 20, 2024
@yuwata
test-network: also set custom altternative name for netdevsim interface
f1f1be7 
Due to the bug in kernel 6.9 caused by
torvalds/linux@8debcf5,
the net_id udev builtin does not work for netdevsim interface.
So, eni99np1 cannot be used with kernel 6.9 anymore.

Workaround for systemd#32910.
@yuwata
test: install more kernel modules for Fedora image
90fe8cf 
Otherwise, several tests for networkd are skipped.

Follow-up for systemd#32666.
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels May 20, 2024
@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review PR is ready for (re-)review by a maintainer labels May 20, 2024
@bluca bluca merged commit 30633af into systemd:main May 20, 2024
35 of 39 checks passed
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label May 20, 2024
@yuwata yuwata deleted the test-network-netdevsim branch May 20, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluca bluca bluca approved these changes

Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TEST-85-NETWORK-NetworkdSRIOVTests failed in GitHub Actions
2 participants
@yuwata @bluca