Removing const / let in favor of var, for Chrome 45. See #2098. #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall size impact on
|
| file | event | diff | master |
issue-2098 |
|---|---|---|---|---|
| extras/amd.js | changed | +6 | 5,279 | 5,285 |
| extras/amd.min.js | changed | -67 | 1,706 | 1,639 |
| extras/global.js | changed | -14 | 2,848 | 2,834 |
| extras/global.min.js | changed | -24 | 814 | 790 |
| extras/module-types.js | changed | -24 | 3,669 | 3,645 |
| extras/module-types.min.js | changed | -14 | 1,601 | 1,587 |
| extras/named-exports.js | changed | +10 | 2,266 | 2,276 |
| extras/named-exports.min.js | changed | -24 | 675 | 651 |
| extras/named-register.js | changed | -24 | 2,327 | 2,303 |
| extras/named-register.min.js | changed | -22 | 883 | 861 |
| extras/transform.js | changed | -6 | 1,163 | 1,157 |
| extras/transform.min.js | changed | -4 | 594 | 590 |
| extras/use-default.js | changed | -4 | 513 | 509 |
| extras/use-default.min.js | changed | -2 | 253 | 251 |
| s.js | changed | +34 | 19,306 | 19,340 |
| s.min.js | changed | -119 | 6,069 | 5,950 |
| system-node.cjs | changed | -142 | 1,397,449 | 1,397,307 |
| system.js | changed | -87 | 29,489 | 29,402 |
| system.min.js | changed | -182 | 9,956 | 9,774 |
Overall size impact: -709 bytes.
Cache impact: 19 files content changed, invalidating a total of 1,486,860 bytes.
guybedford
approved these changes
Apr 7, 2020
src/features/node-fetch.js
Outdated
| @@ -6,12 +6,12 @@ import { fileURLToPath } from 'url'; | |||
| import rimraf from 'rimraf'; | |||
There was a problem hiding this comment.
No need to do it for this file.
src/system-node.js
Outdated
| @@ -7,7 +7,7 @@ import './extras/module-types.js'; | |||
| import './features/node-fetch.js'; | |||
| import { BASE_URL } from './common.js'; | |||
|
|
|||
| export const System = global.System; | |||
| export var System = global.System; | |||
|
The tests are failing for this - it appears the named-exports extra was relying on the semantics of const/let in a way that doesn't work with var. I am working on updating it. |
|
The tests are failing on the master branch, too. I will submit a subsequent PR to fix the tests. |
This was referenced May 2, 2020
1 task
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2098