Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding full dist directory to package.json exports. #2173

Merged
merged 1 commit into from Apr 10, 2020

Conversation

joeldenning
Copy link
Collaborator

Without this, you can't use any of the extras in NodeJS.

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './dist/extras/amd.js' is not defined by "exports" in /Users/joeldenning/code/isomorphic-root-config/node_modules/systemjs/package.json

I considered remapping so that the dist was not necessary in import paths. But I think that would be a breaking change since some people are already doing import 'systemjs/dist/system.js' (at least in webpack bundles) and have the dist in their code.

@github-actions
Copy link

core

File by file impact

Pull request have no impact on core files.

extras

File by file impact

Pull request have no impact on extras files.

Generated by github pull request filesize impact

@guybedford
Copy link
Member

The general rule to consider with path exports is that every file exposed should be an entry point or source map / asset used by an entry point. This meets that criteria fine so seems good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants