Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message for missing content-type header #2197

Merged
merged 3 commits into from
Jun 27, 2020
Merged

Add error message for missing content-type header #2197

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
337ce88
Add error message for missing content-type header
brandones Jun 19, 2020
492f9c3
Update src/extras/module-types.js
brandones Jun 24, 2020
5b674cf
Add tests for missing or invalid content-type headers
brandones Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/extras/module-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import { errMsg } from '../err-msg.js';
if (!res.ok)
throw Error(errMsg(7, process.env.SYSTEM_PRODUCTION ? [res.status, res.statusText, url, parent].join(', ') : res.status + ' ' + res.statusText + ', loading ' + url + (parent ? ' from ' + parent : '')));
var contentType = res.headers.get('content-type');
if (!contentType)
throw Error(errMsg(4, 'Missing header "Content-Type"'));
brandones marked this conversation as resolved.
Show resolved Hide resolved
if (contentType.match(/^(text|application)\/(x-)?javascript(;|$)/)) {
return res.text().then(function (source) {
(0, eval)(source);
Expand Down