Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic import maps #2215

Closed
wants to merge 0 commits into from
Closed

Dynamic import maps #2215

wants to merge 0 commits into from

Conversation

stevenvachon
Copy link
Contributor

Closes #2211

@stevenvachon
Copy link
Contributor Author

The tests pass locally 🤷

@guybedford
Copy link
Member

@stevenvachon thanks for the PR. I'm working on a refactoring to try and simplify the base - on the of the biggest things we need to focus on for the project is keeping the byte footprint down since it is so critical, so a lot of work needs to go into that here still. Were you able to test IE11?

@stevenvachon
Copy link
Contributor Author

... keeping the byte footprint down since it is so critical, so a lot of work needs to go into that here still.

A lot of work on this PR?

Were you able to test IE11?

No, but I can try and figure that out today.

@guybedford
Copy link
Member

@stevenvachon would you mind if I pushed some commits here and rebase this to #2216?

@stevenvachon
Copy link
Contributor Author

I don't mind. I'll create a contingency backup branch.

@guybedford guybedford closed this Jul 23, 2020
@guybedford
Copy link
Member

Hmm, it seems git doesn't like doing this with the master branch... I'm now getting permission denied as the PR got closed.

If you want to reopen this PR we can try again to get the credit. Otherwise I will create a new one.

@guybedford guybedford mentioned this pull request Jul 23, 2020
@stevenvachon
Copy link
Contributor Author

I don't care about the credit.

@guybedford
Copy link
Member

Released in 6.4.0.

@guybedford
Copy link
Member

@stevenvachon I've confirmed this is working in IE11 in 42308a1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic import map updates
2 participants