Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup and simplify auto import cases #2225

Merged
merged 1 commit into from Aug 5, 2020
Merged

Conversation

guybedford
Copy link
Member

This fixes the issues pointed out in #2223 (comment), where the timeout is triggering after the ready state has changed thus cancelling an in-progress auto import.

It turns out the timeout mechanism is actually unnecessary as the process of simply checking the registration to clear it in the dynamic case is all that is needed.

The other mechanism to clear the auto import registry entirely has been removed as it's mostly a GC optimization for some impractical edge cases, whereas most proper usage would never hit those. So it also removes some bytes.

@github-actions
Copy link

github-actions bot commented Aug 5, 2020

core

File by file impact

File Transform Diff master auto-import-fixes Event
dist/s.js none -341 21,896 21,555 changed
gzip -77 6,198 6,121
brotli -72 5,354 5,282
dist/s.min.js none -98 6,659 6,561 changed
gzip -39 2,681 2,642
brotli -35 2,401 2,366
dist/system.js none -341 32,342 32,001 changed
gzip -63 8,697 8,634
brotli -59 7,542 7,483
dist/system.min.js none -98 10,684 10,586 changed
gzip -39 4,125 4,086
brotli -31 3,685 3,654
extras

File by file impact

Pull request have no impact on extras files.

Generated by github pull request filesize impact

@guybedford guybedford merged commit 3bf22cb into master Aug 5, 2020
@guybedford guybedford deleted the auto-import-fixes branch August 5, 2020 17:54
@guybedford
Copy link
Member Author

Released in 6.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant