Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed importmap snippet in Readme #2309

Merged
merged 1 commit into from Mar 10, 2021
Merged

Fixed importmap snippet in Readme #2309

merged 1 commit into from Mar 10, 2021

Conversation

maurer2
Copy link
Contributor

@maurer2 maurer2 commented Mar 10, 2021

Hello, I noticed that the closing script tag was missing from the external importmap example.

Cheers

@github-actions
Copy link

File size impact

Merging patch-1 into master will not impact files in any group.

browser (0/2)

No impact on files in browser group.

node (0/1)

No impact on files in node group.

extras (0/8)

No impact on files in extras group.

Generated by file size impact during size-impact#638941469

@maurer2 maurer2 changed the title Fixed importmap snippet Fixed importmap snippet in Readme Mar 10, 2021
@guybedford guybedford merged commit f9b43bc into systemjs:master Mar 10, 2021
@guybedford
Copy link
Member

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants